Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40057: shorten deprecation timeline and add ticket TODOs #868

Merged
merged 2 commits into from
Jul 23, 2023

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Jul 21, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think you also want quantum.py which has a "v 27" in it.

@TallJimbo
Copy link
Member Author

Thanks for catching quantum.py. Do you know if we have a removal ticket for that deprecation?

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4cd0e03) 87.76% compared to head (c476b38) 87.76%.

❗ Current head c476b38 differs from pull request most recent head 58f80da. Consider uploading reports for the commit 58f80da to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #868   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files         274      274           
  Lines       36057    36057           
  Branches     7562     7562           
=======================================
  Hits        31645    31645           
  Misses       3241     3241           
  Partials     1171     1171           
Impacted Files Coverage Δ
python/lsst/daf/butler/_butler.py 78.89% <ø> (ø)
python/lsst/daf/butler/_limited_butler.py 83.58% <ø> (ø)
python/lsst/daf/butler/_quantum_backed.py 88.17% <ø> (ø)
...hon/lsst/daf/butler/core/dimensions/_coordinate.py 87.15% <ø> (ø)
python/lsst/daf/butler/core/dimensions/_packer.py 80.88% <ø> (ø)
...ython/lsst/daf/butler/core/dimensions/_universe.py 88.53% <ø> (ø)
python/lsst/daf/butler/core/quantum.py 87.43% <ø> (ø)
python/lsst/daf/butler/instrument.py 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj
Copy link
Member

timj commented Jul 21, 2023

If you use "fixup" in your commit messages to indicate they will be squashed later you can add this string to thr do-not-merge action.

@TallJimbo
Copy link
Member Author

If you use "fixup" in your commit messages to indicate they will be squashed later you can add this string to the do-not-merge action.

That's a good idea, because that's actually coming from git commit --fixup, so it is a bit of convention.

@TallJimbo TallJimbo merged commit ee6d72d into main Jul 23, 2023
16 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-40057 branch July 23, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants